Skip to content

Revert "Track and use fallback TextAffinity for null affinity platform TextSelections." #45698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GaryQian merged 1 commit into from
Nov 28, 2019
Merged

Revert "Track and use fallback TextAffinity for null affinity platform TextSelections." #45698

GaryQian merged 1 commit into from
Nov 28, 2019

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Nov 27, 2019

Reverts #44622

See b/145261659

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 27, 2019
DanTup
DanTup approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@GaryQian
Copy link
Contributor Author

GaryQian commented Nov 28, 2019

Merging. Tests passed, the git hooks are not responding.

@GaryQian GaryQian merged commit d345a3b into master Nov 28, 2019
@tvolkert tvolkert deleted the revert-44622-affinity branch December 3, 2019 18:48
@GaryQian GaryQian mentioned this pull request Dec 18, 2019
Closed
@GaryQian GaryQian mentioned this pull request Jan 16, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanTup DanTup DanTup approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GaryQian @DanTup @googlebot @fluttergithubbot