Skip to content

fix reentrant locking in pub upgrade - #4556

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:lock
Jun 14, 2016
Merged

fix reentrant locking in pub upgrade#4556
Hixie merged 1 commit into
flutter:masterfrom
Hixie:lock

Conversation

@Hixie

@Hixie Hixie commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@Hixie

Hixie commented Jun 14, 2016

Copy link
Copy Markdown
Contributor Author

@tvolkert @devoncarew

Feel free to check this in if it has an LGTM and travis is green, I'm going to lunch. :-)

@devoncarew

devoncarew commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

lgtm

@Hixie
Hixie merged commit 294376f into flutter:master Jun 14, 2016
@Hixie
Hixie deleted the lock branch June 14, 2016 19:39
@Hixie

Hixie commented Jun 14, 2016

Copy link
Copy Markdown
Contributor Author

@tvolkert Apparently this may also be an issue with flutter build ios, because xcode re-entrantly calls flutter. I haven't fixed that yet.

@tvolkert

tvolkert commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

FYI, flutter upgrade still hangs on Waiting to be able to obtain lock of Flutter binary artifacts directory... on both Mac and Linux

> flutter upgrade 
Downloading Dart SDK 1.17.1...
######################################################################## 100.0%
Building flutter tool...
A transformer imported unknown package "drudge" (in "package:drudge/drudge.dart").
Downloading Material fonts...                        0.8s
Downloading package sky_engine...                    2.0s
Downloading package sky_services...                  0.3s
Downloading engine artifacts android-arm...          2.1s
Downloading engine artifacts android-arm-profile...  1.9s
Downloading engine artifacts android-arm-release...  1.6s
Downloading engine artifacts android-x64...          1.8s
Downloading engine artifacts android-x86...          1.4s
Downloading engine artifacts ios...                  1.5s
Downloading engine artifacts ios-profile...          1.3s
Downloading engine artifacts ios-release...          1.4s
Downloading darwin-x64 tools...                      1.5s
Downloading android-arm-profile/darwin-x64 tools...  0.7s
Downloading android-arm-release/darwin-x64 tools...  0.7s
Upgrading Flutter from /Users/tvolkert/project/flutter/flutter...
Already up-to-date.

Upgrading engine...
Waiting to be able to obtain lock of Flutter binary artifacts directory...

@Hixie

Hixie commented Jun 14, 2016

Copy link
Copy Markdown
Contributor Author

Yeah, I had a trailing semicolon.

I have a fix for upgrade and build ios.

cdotstout pushed a commit to cdotstout/flutter that referenced this pull request Apr 3, 2018
@aam
Revert "Train frontend_server snapshot (flutter#4512)" (flutter#4556)
e3be1b3 
This reverts commit 86430be as it
breaks Windows engine buildbot.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hixie @devoncarew @tvolkert