Fallback to protocol discovery if mdns returns null #45439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
Contributor
|
Fixes #45468 ? |
Contributor
There was a problem hiding this comment.
Instead of settings this to null with a ternary, set it conditionally:
if (uriFromMdns != null) {
observatoryUri = Stream<Uri>.value(uriFromMdns).asBroadcastStream();
}
Author
There was a problem hiding this comment.
I think being explicit about this value being null at this point is perhaps more readable than assuming it’s already null at this point. Wdyt?
Contributor
|
The failure if from my rolled back change, if you sync it should work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the comment on #44637 (review)
Fixes #45468
Tests
I added the following tests: Unit test
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?