Repository navigation
Conversation
Contributor
Author
|
Blocked by #44471 |
Contributor
Author
|
No longer blocked. :) |
Contributor
Author
|
@goderbauer I would like to land this to close the related issue before doing the refactoring we have discussed offline. Would you be willing to take a look? |
goderbauer
reviewed
Dec 4, 2019
goderbauer
left a comment
Member
There was a problem hiding this comment.
Before we make this widget more complicated, can we split it up into multiple objects? That would make it easier to review this and reason about this.
Contributor
Author
Ok. I will see about addressing the issue when it is re-factored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the fillOverscroll feature of SliverFillRemaining to enable solely filling the overscroll area, rather than also having a child in the natural un-overscrolled scroll view.
This use case applies when SliverFillRemaining's child has no size and the precedingScrollExtent has gone beyond the size of the viewportMainAxisExtent. Prior to this change, this would result in nothing being drawn by SliverFillRemaining. Now it will draw into the overscroll area as it appears. :)
Note:This PR contains changes from #44471, which should land first.I branched from there to prevent a self-inflicted merge conflict. :)Related Issues
Fixes #44353
Tests
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?