Skip to content

Extending fillOverscroll Feature for SliverFillRemaining - #45121

Closed
Piinks wants to merge 12 commits into
flutter:masterfrom
Piinks:overscrollFeat
Closed

Piinks wants to merge 12 commits into
flutter:masterfrom
Piinks:overscrollFeat

Conversation

@Piinks

@Piinks Piinks commented Nov 18, 2019 •

Copy link
Copy Markdown
Contributor

Description

This PR extends the fillOverscroll feature of SliverFillRemaining to enable solely filling the overscroll area, rather than also having a child in the natural un-overscrolled scroll view.

This use case applies when SliverFillRemaining's child has no size and the precedingScrollExtent has gone beyond the size of the viewportMainAxisExtent. Prior to this change, this would result in nothing being drawn by SliverFillRemaining. Now it will draw into the overscroll area as it appears. :)


Note:
This PR contains changes from #44471, which should land first.
I branched from there to prevent a self-inflicted merge conflict. :)


Related Issues

Fixes #44353

Tests

  • fillOverscroll works when child has no size and precedingScrollExtent > viewportMainAxisExtent

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Piinks Piinks added c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Nov 18, 2019
@Piinks

Piinks commented Nov 20, 2019

Copy link
Copy Markdown
Contributor Author

Blocked by #44471

@Piinks

Piinks commented Nov 26, 2019

Copy link
Copy Markdown
Contributor Author

No longer blocked. :)

@Piinks

Piinks commented Dec 3, 2019 •

Copy link
Copy Markdown
Contributor Author

@goderbauer I would like to land this to close the related issue before doing the refactoring we have discussed offline. Would you be willing to take a look?

@Piinks
Piinks requested a review from goderbauer December 3, 2019 20:54

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we make this widget more complicated, can we split it up into multiple objects? That would make it easier to review this and reason about this.

@Piinks

Piinks commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

Before we make this widget more complicated, can we split it up into multiple objects? That would make it easier to review this and reason about this.

Ok. I will see about addressing the issue when it is re-factored.

@Piinks Piinks closed this Dec 4, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
@Piinks
Piinks deleted the overscrollFeat branch March 14, 2025 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: new feature Nothing broken; request for a new capability f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SliverFillRemaining does not fill overscroll even with fillOverscroll option

3 participants