Skip to content

Revert "reland add new enum change (#44281) (#44487)" #44947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chunhtai merged 1 commit into from
Nov 15, 2019
Merged

Revert "reland add new enum change (#44281) (#44487)" #44947

chunhtai merged 1 commit into from
Nov 15, 2019

Conversation

@iskakaushik
Copy link
Contributor

@iskakaushik iskakaushik commented Nov 14, 2019

This reverts commit f079491.

@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 14, 2019
jmagman
jmagman approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert, RSLGTM

chunhtai
chunhtai approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunhtai chunhtai merged commit 75f3107 into flutter:master Nov 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iskakaushik @jmagman @chunhtai @googlebot @fluttergithubbot