Fix "node._relayoutBoundary == _relayoutBoundary" crash #44490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
Member
|
LGTM, but I don't know enough about relayoutBoundaries or the ramifications of the change. Thanks for fixing this! I think that this is also going to fix an issue on Flutter for web, when the app starts rendered in a hidden iframe and then it gets shown! 🎉 |
goderbauer
approved these changes
Nov 11, 2019
Member
There was a problem hiding this comment.
nit: the predominant style in the repository for this is:
Suggested change
| // originally reported as https://github.com/flutter/flutter/issues/39151 | |
| // Regression test for https://github.com/flutter/flutter/issues/39151. |
Hixie
force-pushed
the
relayoutboundary
branch
from
968cf03 to
99c761a
Compare
Contributor
Author
|
Updated; will land on green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39151.
Fundamentally the problem was that in certain situations, we would change a RenderObject's idea of what the repaint boundary was, but we would forget to tell children that the repaint boundary had also changed, and so when they went and verified that their repaint boundary was still correct, they found the tree was inconsistent.
cc @goderbauer @ditman