Skip to content

Adding flutter_goldens tests to misc shards #44479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Piinks merged 1 commit into from
Nov 15, 2019
Merged

Adding flutter_goldens tests to misc shards #44479

Piinks merged 1 commit into from
Nov 15, 2019

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Nov 8, 2019 •
edited
Loading

Description

This PR adds the flutter_goldens package tests to the miscellaneous test shards. Previously these tests were not running. :)

Tests

Turned on!

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. labels Nov 8, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 8, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks requested a review from Hixie November 8, 2019 23:14
@Piinks Piinks changed the title Adding flutter_goldens tests to Misc shards Adding flutter_goldens tests to misc shards Nov 8, 2019
@Piinks Piinks mentioned this pull request Nov 11, 2019
Merged
10 tasks
goderbauer
goderbauer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit 7aa5b07 into flutter:master Nov 15, 2019
@Piinks Piinks deleted the goldensPkgTests branch November 22, 2019 00:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @fluttergithubbot @goderbauer @googlebot