revert add new enum change #44281
Merged
revert add new enum change #44281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
framework
chunhtai
force-pushed
the
issues/39832-revert
branch
from
3134c11 to
ee053d2
Compare
chunhtai
force-pushed
the
issues/39832-revert
branch
from
ee053d2 to
0438dec
Compare
chunhtai
force-pushed
the
issues/39832-revert
branch
from
0438dec to
ea78ae0
Compare
iskakaushik
approved these changes
Nov 6, 2019
Contributor
iskakaushik
left a comment
iskakaushik
left a comment
There was a problem hiding this comment.
RSLGTM for the revert.
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Nov 14, 2019
This reverts commit ed82bb8.
chunhtai
added a commit
that referenced
this pull request
Nov 14, 2019
iskakaushik
pushed a commit
to iskakaushik/flutter
that referenced
this pull request
Nov 14, 2019
This reverts commit f079491.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change revert new enum change and remove the dependency of suspending state for soft transition.
Related Issues
#39832
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?