Observe logging from VM service on iOS 13 #43915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
jmagman
commented
Oct 31, 2019
Member
Author
There was a problem hiding this comment.
This needs a test, working on it...
Contributor
There was a problem hiding this comment.
won't this fail if device.majorSdkVersion == null?
jmagman
commented
Oct 31, 2019
Member
Author
There was a problem hiding this comment.
This part is a little over-engineered in the dance between _linesController starting and setting connectedVMServices. I'll simplify.
Contributor
There was a problem hiding this comment.
wow, does this verify that an assignment happened? I didn't know you could do that.
Member
Author
There was a problem hiding this comment.
Seems to. From the mockito docs:
// You can verify setters.
cat.lives = 9;
verify(cat.lives=9);
Contributor
There was a problem hiding this comment.
I've skimmed that README many times and yet seem to have missed that. Cool.
Member
Author
|
This doesn't fix the driver tests, that's a DIFFERENT VM service interface. |
9 tasks
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
This was referenced Sep 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IOSDeviceLogReader observes Stdout stream from VMService if version is iOS 13+ to print dart and engine logs. Keep using syslog on older versions since that will additionally provide logs if the app crashes.
Similar to resident_web_runner behavior:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart#L295
Related Issues
Fixes #41133.
Tests
New resident_runner_test and devices_test.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change