Avoid using FlutterError.fromParts when possible #43696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
a: tests
jacob314
approved these changes
Oct 29, 2019
Contributor
jacob314
left a comment
jacob314
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up.
HansMuller
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
Contributor
|
@adalberht, are you still planning on landing this PR? It has been approved, but needs to have the file conflicts resolved. |
albertusdev
force-pushed
the
flutter-error-consistency
branch
2 times, most recently
from
72e7bd2 to
24cba57
Compare
- Remove not important todos - Fix indent consistencies
albertusdev
force-pushed
the
flutter-error-consistency
branch
from
0168273 to
b1364a6
Compare
Contributor
Author
|
Hey @gspencergoog, this PR should be ready to be landed once the CI is green now. |
Contributor
|
Great, I'll land it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up of https://github.com/flutter/flutter/pull/42640/files
Some changes of that PR includes redundant changes using FlutterError.fromParts constructor even though it's not necessary
Some minor changes are:
Related Issues
none
Tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?