Description

This will re-land the changes introduced in #40710, which were reverted after golden file tests started to time out when making requests to the details/ api.

What's Changed

Noted below, the case for querying the details/ api has been changed.

Before:

• While iterating through expectations, the details/ were checked for each failure while looking for a positive

Now:

• The details/ are only checked after no positive has been found, rather than in step with the initial pass through
• This ensures that this call will only be made in cases where a golden file has changed, which is expected far less often than at every test execution as it was before.

The details/ api is also scheduled for performance improvements, tracking available here https://bugs.chromium.org/p/skia/issues/detail?id=9557 for Gold side changes.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I signed the CLA.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I updated/added relevant documentation (doc comments with ///).
• All existing and new tests are passing.
• The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

• Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
• No, this is not a breaking change.