Skip to content

Revert "CupertinoDatePicker & CupertinoTimerPicker dark mode" #41521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LongCatIsLooong merged 1 commit into from
Sep 28, 2019
Merged

Revert "CupertinoDatePicker & CupertinoTimerPicker dark mode" #41521

LongCatIsLooong merged 1 commit into from
Sep 28, 2019

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 27, 2019

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes will affect goldens Changes to golden files labels Sep 27, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 27, 2019

It looks like this pull request includes a golden file change. Please make sure to follow Handling Breaking Changes. While there are exceptions to this rule, if this patch modifies an existing golden file, it is probably not an exception. Only new golden files are not considered breaking changes.

Writing a golden file test for package:flutter may also provide guidance for this change.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks
Copy link
Contributor

Piinks commented Sep 28, 2019

It looks like this pull request includes a golden file change. Please make sure to follow Handling Breaking Changes. While there are exceptions to this rule, if this patch modifies an existing golden file, it is probably not an exception. Only new golden files are not considered breaking changes.

Writing a golden file test for package:flutter may also provide guidance for this change.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Disregard. This is currently triggered by changes to goldens.version

Piinks
Piinks approved these changes Sep 28, 2019
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks removed c: API break Backwards-incompatible API changes will affect goldens Changes to golden files labels Sep 28, 2019
@LongCatIsLooong LongCatIsLooong merged commit 5f9c262 into master Sep 28, 2019
@LongCatIsLooong LongCatIsLooong deleted the revert-39919-dark-mode-d branch September 28, 2019 00:46
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@LongCatIsLooong @Inconnu08
Revert "CupertinoDatePicker & CupertinoTimerPicker dark mode (flutter…
8ac0a98 
…#39919)" (flutter#41521)
LongCatIsLooong added a commit to LongCatIsLooong/flutter that referenced this pull request Sep 30, 2019
@LongCatIsLooong
Reland "CupertinoDatePicker & CupertinoTimerPicker dark mode (flutter…
5d553d5 
…#39919)" (flutter#41521)"

This reverts commit 5f9c262.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LongCatIsLooong @fluttergithubbot @Piinks @googlebot