[Chip] Make sure InkResponse is in the foreground on delete for chips with background color #41463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perclasson
requested review from
clocksmith,
johnsonmh,
rami-a and
willlarche
fluttergithubbot
added
f: material design
clocksmith
reviewed
Sep 27, 2019
Contributor
There was a problem hiding this comment.
Is there a way to test that the ink renders in the foreground without testing the implementation?
Contributor
Author
There was a problem hiding this comment.
I added a test for this now.
perclasson
force-pushed
the
fix_material_chip_bug
branch
from
fb6ca90 to
3319984
Compare
perclasson
force-pushed
the
fix_material_chip_bug
branch
from
3319984 to
14c1e57
Compare
perclasson
force-pushed
the
fix_material_chip_bug
branch
from
14c1e57 to
300a0ed
Compare
willlarche
force-pushed
the
fix_material_chip_bug
branch
from
741dd65 to
428e1d8
Compare
perclasson
requested review from
HansMuller
and removed request for
Piinks and
jmagman
rami-a
approved these changes
Oct 11, 2019
HansMuller
approved these changes
Oct 21, 2019
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM with a few small suggestions.
clocksmith
reviewed
Oct 23, 2019
clocksmith
reviewed
Oct 23, 2019
clocksmith
approved these changes
Oct 23, 2019
Contributor
Author
|
This PR was conflicting with the following PR and thus a test for this branch failed on master: |
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
… with background color (flutter#41463) * Make sure InkResponse is visible on delete for chips with background color set * Override computeDistanceToActualBaseline in layout builder
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…or chips with background color (flutter#41463)" (flutter#43391) This reverts commit 588275e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For chips with background color set the ripple is not in the foreground, but behind the chip.
Reason for this bug is described here:
https://api.flutter.dev/flutter/material/InkResponse-class.html#the-ink-splashes-arent-visible
Screenshot before:
Screenshot after:
Related Issues
#41461 [Chip] Delete icon ripple not visible for Chip when background color is set
Tests
I added the following tests:
packages/flutter/test/material/chip_test.dart
'Chips should use Ink instead of Container for delete icon ripple'
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?