Skip to content

Conversation

@tvolkert
Copy link
Contributor

roll ios-deploy version to 2fbbee77ea2b3212959b9dddda816f59094cd7cd (#40398)

@fluttergithubbot fluttergithubbot added the engine flutter/engine related. See also e: labels. label Sep 24, 2019
@tvolkert tvolkert changed the base branch from master to v1.9.1-hotfixes September 24, 2019 15:48
@fluttergithubbot
Copy link
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.9.1-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot changed the base branch from v1.9.1-hotfixes to master September 24, 2019 15:48
@tvolkert tvolkert changed the base branch from master to v1.9.1-hotfixes September 24, 2019 15:48
@christopherfujino
Copy link
Contributor

I'm guessing the CocoaPods failures are the issue @digiter mentioned in infra discord about our VMs installing tip of tree cocoapods?

@christopherfujino
Copy link
Contributor

@tvolkert do we also hotfix the cirrus change, or do we just leave the tests failing? #41145

@tvolkert
Copy link
Contributor Author

Yeah, all cherry-picks to this branch have seen these failures - I've been ignoring them.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit 1ced75c into flutter:v1.9.1-hotfixes Sep 24, 2019
@tvolkert tvolkert deleted the v1.9.1-hotfixes branch September 24, 2019 17:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants