Skip to content

Add embedding as API dependency instead of compile only dependency #41142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 5 commits into from
Sep 26, 2019
Merged

Add embedding as API dependency instead of compile only dependency #41142

blasten merged 5 commits into from
Sep 26, 2019

Conversation

@blasten
Copy link

@blasten blasten commented Sep 23, 2019 •
edited
Loading

Description

Adds the embedding as API dependency so default implementation of abstract methods are desugared in the runtime classpath.

Related Issues

Fixes #40126

Tests

Integration test that runs on Firebase Test Lab.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 23, 2019
@blasten blasten force-pushed the gradle_3_5_patch branch 3 times, most recently from c7caf5c to 4fb2942 Compare September 24, 2019 23:15
@blasten blasten requested a review from mklim September 24, 2019 23:23
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 24, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 24, 2019
@blasten
Copy link
Author

blasten commented Sep 25, 2019

@mklim I removed all the binaries. PTAL

mklim
mklim approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this!

dev/integration_tests/abstract_method_smoke_test/lib/main.dart Outdated
children: <Widget>[
TextFormField(),
const Expanded(
child: InAppWebView(
Copy link
Contributor

@mklim mklim Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and we can use google_maps_flutter here instead, which I think I'd prefer since that's in flutter/plugins.

Suggested change
child: InAppWebView(
child: GoogleMap(initialCameraPosition: CameraPosition(target: LatLng(0, 0))),

AndroidManifest.xml also needs to be updated to have a property for an API key. I'd just add a sample one (<meta-data android:name="com.google.android.geo.API_KEY" android:value="your API key"/>) since we don't need it to render.

Copy link
Author

@blasten blasten Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg. Done

@mklim mklim mentioned this pull request Sep 25, 2019
Closed
9 tasks
@blasten blasten merged commit 975e770 into flutter:master Sep 26, 2019
@blasten blasten deleted the gradle_3_5_patch branch September 26, 2019 00:59
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Add embedding as API dependency instead of compile only dependency (f…
c6d2208 
…lutter#41142)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mklim mklim mklim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

java.lang.AbstractMethodError: abstract method "void io.flutter.plugin.platform.PlatformView.onInputConnectionLocked()"

4 participants

@blasten @fluttergithubbot @mklim @googlebot