Skip to content

Conversation

@ljg-7f
Copy link

@ljg-7f ljg-7f commented Sep 23, 2019

add --flavor-assets-dir parameter. Directory for storing different flavor's assets. When compiling, only the specified flavor directory will be loaded from this directory. --flavor-assets-dir and --flavor are used in combination.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams
Copy link
Contributor

@Liujingguang we should support loading flavor specific assets, but this is not the approach that I would take. For more information see #21682. Instead, we should probably update the asset manifest to allow specifying flavor/platform/mode et cetera and otherwise preserve the existing behavior.

If you're interested in working on this, i can give some pointers - or we could discuss in chat

@jonahwilliams jonahwilliams added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Oct 3, 2019
@ljg-7f
Copy link
Author

ljg-7f commented Oct 8, 2019

add --flavor-assets-dir parameter. Directory for storing different flavor's assets. When compiling, only the specified flavor directory will be loaded from this directory. --flavor-assets-dir and --flavor are used in combination.

@ljg-7f ljg-7f closed this Oct 8, 2019
@ljg-7f ljg-7f reopened this Oct 8, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ljg-7f
Copy link
Author

ljg-7f commented Oct 8, 2019

@Liujingguang we should support loading flavor specific assets, but this is not the approach that I would take. For more information see #21682. Instead, we should probably update the asset manifest to allow specifying flavor/platform/mode et cetera and otherwise preserve the existing behavior.

If you're interested in working on this, i can give some pointers - or we could discuss in chat

@jonahwilliams This PR is mainly for the specific loading of resources for the flavor, and does not consider the factors of platform and mode. If you consider platform and mode, the idea is similar to the PR.
The resources that need to be distinguished according to flavor/platform/mode are uniformly placed in a folder, and the name of the folder is specified by --flavor-assets-dir (or other parameters), so that it allows you to filter specific resources based on the flavor/platform/mode information in this folder.

What is the method you want to take?

@zanderso zanderso removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Oct 17, 2019
@jonahwilliams
Copy link
Contributor

Passing flavor through the tool invocations is fine, since it allows the flutter tool to determine via the asset manifest which assets to include. What advantage does also specifying a flavor asset directory have over this?

@ljg-7f
Copy link
Author

ljg-7f commented Oct 18, 2019

Passing flavor through the tool invocations is fine, since it allows the flutter tool to determine via the asset manifest which assets to include. What advantage does also specifying a flavor asset directory have over this?

The idea of multi-channel resource filtering originally came from Android. Putting all resources in one folder can be managed in a unified way. The directory level will be clear. What's more, it can facilitate us to filter specific resources. If you have a better plan, please let me know.

@ckdgit
Copy link

ckdgit commented Nov 1, 2019

I think this is a point to reduce the size of the installation package,In different flavor,we use different resource files, We don't need to import other resource files from other flavors,and we can use the one same yaml file, it's important.

@jonahwilliams
Copy link
Contributor

I'm not against the idea of flavor specific assets or further filtering of assets, but this isn't the way I'd like to see it done

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants