Benchmark for un-triaged image results on Flutter Gold #40634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
a: tests
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
c: contributor-productivity
11 tasks
goderbauer
reviewed
Sep 18, 2019
Contributor
Author
|
Hold on merging. Checking with @kjlubick on sanity of this API call. 🙂 |
Piinks
changed the title
kjlubick
requested changes
Sep 20, 2019
| int digestCount = 0; | ||
| try { | ||
| final HttpClientRequest request = await skiaClient.getUrl(Uri.parse( | ||
| 'https://flutter-gold.skia.org/json/byblame?query=source_type%3Dflutter' |
Contributor
There was a problem hiding this comment.
https://flutter-gold.skia.org/json/trstatus is more direct endpoint here.
kjlubick
approved these changes
Sep 20, 2019
Piinks
changed the title
Piinks
added a commit
that referenced
this pull request
Sep 24, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…er#40634)" (flutter#41232) This reverts commit 43932aa.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a simple benchmark that tracks the number of un-triaged digests on Flutter Gold.
Having this benchmark in place will help safe guard against forgotten image changes as we move way from using flutter/goldens and towards Flutter Gold. :)
Related work:
WIP Skia Gold Support for Local & PreSubmit Testing in package:flutter #39853Skia Gold Support for Local & PreSubmit Testing in package:flutter #40710Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?