enable foundation and physics tests on the Web #40630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
c: contributor-productivity
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
force-pushed
the
re-enable-web-tests
branch
5 times, most recently
from
c7638a4 to
5ab48cd
Compare
yjbanov
force-pushed
the
re-enable-web-tests
branch
from
5ab48cd to
7892074
Compare
yjbanov
force-pushed
the
re-enable-web-tests
branch
from
66b65c3 to
775a66f
Compare
…DK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests. Enable foundation and physics tests on the Web.
yjbanov
force-pushed
the
re-enable-web-tests
branch
from
775a66f to
5dda51f
Compare
jonahwilliams
approved these changes
Oct 1, 2019
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Lets Get Those Mtests !
Codecov Report
@@ Coverage Diff @@
## master #40630 +/- ##
==========================================
+ Coverage 60.71% 60.8% +0.08%
==========================================
Files 193 193
Lines 18893 18893
==========================================
+ Hits 11471 11487 +16
+ Misses 7422 7406 -16
Continue to review full report at Codecov.
|
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…DK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests. (flutter#40630) Spawn no more than 1 iframe in web tests. Using multiple iframes in DDK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable foundation and physics tests on Cirrus.