Reland: implement build bundle with assemble #40470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 2, 2019 12:16
…to bundle_assemble
…to bundle_assemble
fluttergithubbot
added
c: contributor-productivity
jonahwilliams
changed the title
Codecov Report
@@ Coverage Diff @@
## master #40470 +/- ##
==========================================
- Coverage 59.75% 59.29% -0.47%
==========================================
Files 193 193
Lines 18705 18795 +90
==========================================
- Hits 11177 11144 -33
- Misses 7528 7651 +123
Continue to review full report at Codecov.
|
jonahwilliams
changed the title
jmagman
approved these changes
Sep 18, 2019
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Last 3 commits since the master merge LGTM
zanderso
approved these changes
Sep 18, 2019
| final PoolResource resource = await pool.request(); | ||
| try { | ||
| final File file = fs.file(fs.path.join(environment.outputDir.path, entry.key)); | ||
| file.parent.createSync(recursive: true); |
Member
There was a problem hiding this comment.
What happens when one of these file operations fails?
Contributor
Author
There was a problem hiding this comment.
We should throw, will update
Contributor
Author
There was a problem hiding this comment.
actually, we're already propagating the future, just ensuring that the resource is released first
|
|
||
| void _writeFilesToBuffer(List<File> files, StringBuffer buffer) { | ||
| for (File outputFile in files) { | ||
| if (platform.isWindows) { |
Contributor
Author
|
I can't see if the devicelab failure is real or not, so I'll rollback for now |
jonahwilliams
pushed a commit
that referenced
this pull request
Sep 19, 2019
This reverts commit ea7876a.
jonahwilliams
pushed a commit
that referenced
this pull request
Sep 19, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a reland of #37508. The depfile's were not correctly escaped for windows, which caused failures when rebuilding.
Additionally fixes a bug in the file cache cleanup, and ensures we use a package uri when building a snapshot in assemble.