Skip to content

Dark Mode R: Refresh Control #40454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LongCatIsLooong merged 2 commits into from
Sep 14, 2019
Merged

Dark Mode R: Refresh Control #40454

LongCatIsLooong merged 2 commits into from
Sep 14, 2019

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 13, 2019 •
edited
Loading

Description

CupertinoSliverRefreshControl. Router is done in a previous PR (but the shadow color may need to be revised in the future).

Related Issues

part of #35541

Tests

I added the following tests:

  • buildSimpleRefreshIndicator dark mode

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Sep 13, 2019
justinmc
justinmc approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Watch out for breaking goldens tests.

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Sep 13, 2019

I don't think this PR breaks any existing goldens. flutter test didn't complain.

@LongCatIsLooong LongCatIsLooong merged commit 19b47c2 into flutter:master Sep 14, 2019
@LongCatIsLooong LongCatIsLooong deleted the dark-mode-R branch September 14, 2019 00:18
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@LongCatIsLooong @Inconnu08
Dark Mode R: Refresh Control (flutter#40454)
86d352a
@HansMuller HansMuller mentioned this pull request Nov 25, 2019
Closed
18 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@justinmc justinmc justinmc approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LongCatIsLooong @justinmc @googlebot @fluttergithubbot