Skip to content

Make FlutterPluginRegistrant a static framework so add-to-app can use static framework plugins #40401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Sep 13, 2019
Merged

Make FlutterPluginRegistrant a static framework so add-to-app can use static framework plugins #40401

jmagman merged 1 commit into from
Sep 13, 2019

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 12, 2019

Description

If host app Podfiles are using use_frameworks! and plugins vended as static frameworks (google_maps_flutter, google_sign_in etc) then FlutterPluginRegistrant must also be a static framework. I don't see a non-hacky way to parse the plugins at the point the template is generated, so I think FlutterPluginRegistrant just has to always be a static framework.

Related Issues

Fixes #31104.

Tests

I updated module_test_ios to use_frameworks! with google_sign_in on top of the new Swift test in #40302 and confirmed it failed before this change and succeeded after. Don't have a running CI test for this yet.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Sep 12, 2019
@jmagman jmagman requested a review from xster September 12, 2019 23:44
@jmagman jmagman self-assigned this Sep 12, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 12, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@xster
Copy link
Member

xster commented Sep 12, 2019

LGTM. I don't see any cons to this approach.

@codecov
Copy link

codecov bot commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #40401 into master will decrease coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40401      +/-   ##
==========================================
- Coverage   58.78%   57.83%   -0.96%     
==========================================
  Files         192      192              
  Lines       18596    18597       +1     
==========================================
- Hits        10932    10755     -177     
- Misses       7664     7842     +178
Flag Coverage Δ
#flutter_tool 57.83% <ø> (-0.96%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/plugins.dart 78.08% <ø> (ø) ⬆️
...kages/flutter_tools/lib/src/linux/build_linux.dart 0% <0%> (-86.49%) ⬇️
packages/flutter_tools/lib/src/linux/makefile.dart 0% <0%> (-80%) ⬇️
packages/flutter_tools/lib/src/ios/simulators.dart 2.77% <0%> (-46.02%) ⬇️
...ges/flutter_tools/lib/src/build_system/source.dart 54.05% <0%> (-32.44%) ⬇️
...lutter_tools/lib/src/android/android_workflow.dart 37.1% <0%> (-26.42%) ⬇️
...es/flutter_tools/lib/src/commands/build_linux.dart 65% <0%> (-20%) ⬇️
...ckages/flutter_tools/lib/src/reporting/events.dart 78.57% <0%> (-19.65%) ⬇️
packages/flutter_tools/lib/src/ios/mac.dart 39.8% <0%> (-13.7%) ⬇️
packages/flutter_tools/lib/src/base/utils.dart 87.62% <0%> (-5.95%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72888c7...a64bca1. Read the comment docs.

@jmagman jmagman merged commit ba13aa9 into flutter:master Sep 13, 2019
@jmagman jmagman deleted the static-fw branch September 13, 2019 01:55
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@jmagman @Inconnu08
Make FlutterPluginRegistrant a static framework so add-to-app can use…
fd1f685 
… plugins with static frameworks (flutter#40401)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] iOS - undefined symbols for architecture

4 participants

@jmagman @fluttergithubbot @xster @googlebot