Dark mode CupertinoNavigationBar #40189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: cupertino
LongCatIsLooong
requested review from
HansMuller,
darrenaustin and
justinmc
justinmc
approved these changes
Sep 11, 2019
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM, just some small comments.
|
|
||
| final Color actionsForegroundColor = CupertinoDynamicColor.resolve( | ||
| widget.actionsForegroundColor, // ignore: deprecated_member_use_from_same_package | ||
| context |
| ), | ||
| ); | ||
| expect(find.byType(BackdropFilter), findsNothing); | ||
| expect(find.byType(CupertinoNavigationBar), paints..rect(color: const Color(0xFFE5E5E5))); |
Contributor
There was a problem hiding this comment.
Could you use background.color for this color here?
| ), | ||
| ); | ||
| expect(find.byType(BackdropFilter), findsOneWidget); | ||
| expect(find.byType(CupertinoNavigationBar), paints..rect(color: const Color(0xF3E5E5E5))); |
Contributor
There was a problem hiding this comment.
Also here, background.darkColor
LongCatIsLooong
added a commit
to flutter/goldens
that referenced
this pull request
Sep 16, 2019
Piinks
approved these changes
Sep 16, 2019
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM, is this the minor golden change you mentioned offline? If so, I wouldn't consider it breaking. I would just make sure it is included in the change log.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
CupertinoNavigationBarandCupertinoSliverNavigationBarso they handle dynamic colors. No screenshots because the appearance change is minimal: flutter/goldens#44Related Issues
part of #35541
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
Not sure if this is breaking as the golden changes seem to be minimal.