Skip to content

Update Kotlin and Gradle version - #40181

Merged
blasten merged 14 commits into
flutter:masterfrom
blasten:kotlin_migration
Sep 14, 2019
Merged

Update Kotlin and Gradle version#40181
blasten merged 14 commits into
flutter:masterfrom
blasten:kotlin_migration

Conversation

@blasten

@blasten blasten commented Sep 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Fixes conflict in #32550

Removed FlutterEventLogger since it doesn't rethrow Gradle failures anymore.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 10, 2019
@fluttergithubbot

fluttergithubbot commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@googlebot

googlebot commented Sep 10, 2019

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@blasten
blasten requested a review from dnfield September 10, 2019 21:30
@blasten

blasten commented Sep 10, 2019

Copy link
Copy Markdown
Author

@ened would you be ok if I take over #32550? If yes, please leave a comment that only contains @googlebot I consent.

@blasten blasten mentioned this pull request Sep 10, 2019
Closed
8 of 9 tasks
@ened

ened commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@googlebot

googlebot commented Sep 10, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ened

ened commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

@blasten, of course. Go crazy. :-)

@codecov

codecov Bot commented Sep 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #40181 into master will increase coverage by 0.84%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40181      +/-   ##
==========================================
+ Coverage   57.83%   58.68%   +0.84%     
==========================================
  Files         192      192              
  Lines       18695    18443     -252     
==========================================
+ Hits        10812    10823      +11     
+ Misses       7883     7620     -263
Flag Coverage Δ
#flutter_tool 58.68% <0%> (+0.84%) ⬆️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/android/gradle.dart 62.39% <0%> (+0.76%) ⬆️
...ackages/flutter_tools/lib/src/commands/attach.dart 47.34% <0%> (-27.13%) ⬇️
...ackages/flutter_tools/lib/src/resident_runner.dart 45.81% <0%> (-10.9%) ⬇️
...ages/flutter_tools/lib/src/base/user_messages.dart 47.16% <0%> (-4.19%) ⬇️
...tools/lib/src/windows/visual_studio_validator.dart 89.47% <0%> (-3.86%) ⬇️
packages/flutter_tools/lib/src/device.dart 58.23% <0%> (-3.53%) ⬇️
...lutter_tools/lib/src/android/android_emulator.dart 63.26% <0%> (-3.41%) ⬇️
.../flutter_tools/lib/src/runner/flutter_command.dart 77.63% <0%> (-3.33%) ⬇️
packages/flutter_tools/lib/src/macos/xcode.dart 57.14% <0%> (-2.54%) ⬇️
...ages/flutter_tools/lib/src/commands/build_web.dart 71.42% <0%> (-1.91%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b47c2...893f60d. Read the comment docs.

dnfield
dnfield reviewed Sep 11, 2019
View reviewed changes
Comment thread packages/flutter_tools/gradle/flutter.gradle Resolved
dnfield
dnfield approved these changes Sep 11, 2019
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - would appreciate clarifications in the PR description about why we're not moving to head on these versions (or just move them to head if there's nothing blocking it).

@yaymalaga yaymalaga mentioned this pull request Sep 11, 2019
Closed
@blasten blasten mentioned this pull request Sep 13, 2019
Merged
8 of 9 tasks
@blasten
blasten merged commit 4d404da into flutter:master Sep 14, 2019
@blasten
blasten deleted the kotlin_migration branch September 14, 2019 02:37
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
Emmanuel Garcia @Inconnu08
Update Kotlin and Gradle version (flutter#40181)
1da4198
@repentsinner repentsinner mentioned this pull request Dec 14, 2019
Closed
@jmagman jmagman mentioned this pull request Feb 27, 2020
Closed
@koji-1009 koji-1009 mentioned this pull request Mar 23, 2021
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ened ened ened left review comments
+1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blasten @fluttergithubbot @googlebot @ened @dnfield