Revert engine roll #40112
Merged
Revert engine roll #40112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hem more inline with topaz. (flutter/engine#12034) (flutter#40018)" This reverts commit 5a3a46a.
This reverts commit af07bb5.
Contributor
|
did we file a TODAY bug to bisect which engine change triggered this and restart the engine auto-roller? |
Contributor
|
Ah, nevermind - if I look 1 inch above my comment, I see the reference to #40114 😜 |
flar
referenced
this pull request
Sep 11, 2019
…nline with topaz. (flutter/engine#12034) (#40018) [email protected]:flutter/engine.git/compare/50bdbd769eee...c9ea4db git log 50bdbd7..c9ea4db --no-merges --oneline 2019-09-06 [email protected] [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter/engine#12034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
flar
referenced
this pull request
Sep 11, 2019
[email protected]:flutter/engine.git/compare/7ea9884ab00e...50bdbd7 git log 7ea9884..50bdbd7 --no-merges --oneline 2019-09-06 [email protected] Document dependencies and remove support-v13 (flutter/engine#11912) 2019-09-06 [email protected] Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 2019-09-06 [email protected] Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter/engine#12031) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting the engine rolls that seem to have caused the following devicelab tests to start timing out:
flutter_gallery_ios32__transition_perfandflutter_gallery_ios32__start_up.Specifically, they started failing when af07bb5 was committed.