CupertinoAlertDialog dark mode & CupertinoActionSheet fidelity #40007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: cupertino
LongCatIsLooong
commented
Sep 7, 2019
| context: context, | ||
| barrierDismissible: false, | ||
| barrierColor: _kModalBarrierColor, | ||
| barrierColor: CupertinoDynamicColor.resolve(_kModalBarrierColor, context), |
Contributor
Author
There was a problem hiding this comment.
The caveat of doing this is, the color won't change unless the dialog is dismissed then shown again.
Contributor
There was a problem hiding this comment.
Seems OK. Even if we recreated showGeneralDialog's _DialogRoute, it still wouldn't be easy to get the scrim to redraw when the platform's brightness changed.
HansMuller
approved these changes
Sep 11, 2019
| context: context, | ||
| barrierDismissible: false, | ||
| barrierColor: _kModalBarrierColor, | ||
| barrierColor: CupertinoDynamicColor.resolve(_kModalBarrierColor, context), |
Contributor
There was a problem hiding this comment.
Seems OK. Even if we recreated showGeneralDialog's _DialogRoute, it still wouldn't be easy to get the scrim to redraw when the platform's brightness changed.
6 tasks
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
18 tasks
Contributor
|
This PR caused a regression as discussed in #50183 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CupertinoAlertDialogandCupertinoActionSheetModalBarriercolor that used for cupertino popup routesCupertinoAlertDialogdark mode.Related Issues
Part of #35541
Fixes #39941
Fixes #20469
Screenshots (iPhone XR device, iOS 13.1 17A5831c)
The native alert view has some additional visual effects that we have yet to add to
CupertinoAlertDialog, so it looks more opaque thanCupertinoAlertDialogin the screenshots below.Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?