Skip to content

Make CupertinoDynamicColor.resolve return null when given a null color #39927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LongCatIsLooong merged 3 commits into from
Sep 6, 2019
Merged

Make CupertinoDynamicColor.resolve return null when given a null color #39927

LongCatIsLooong merged 3 commits into from
Sep 6, 2019

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 5, 2019 •
edited
Loading

Description

For convenience.

Tests

I added the following tests:

  • can resolve null color

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Sep 5, 2019
@LongCatIsLooong LongCatIsLooong mentioned this pull request Sep 5, 2019
Merged
9 tasks
HansMuller
HansMuller approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/cupertino/colors.dart Outdated
/// Resolves the given [Color] by calling [resolveFrom].
///
/// If the given color is already a concrete [Color], it will be returned as is.
/// If the given color is null, returns null for convenience.
Copy link
Contributor

@HansMuller HansMuller Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't really need to say "for convenience".

Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye

@LongCatIsLooong LongCatIsLooong merged commit 8661dc4 into flutter:master Sep 6, 2019
@LongCatIsLooong LongCatIsLooong deleted the lift-resolve branch September 6, 2019 16:58
@justinmc justinmc mentioned this pull request Sep 6, 2019
Closed
6 tasks
@HansMuller HansMuller mentioned this pull request Oct 18, 2019
Closed
18 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LongCatIsLooong @HansMuller @googlebot @fluttergithubbot