Skip to content

Conversation

@encosw
Copy link

@encosw encosw commented Sep 5, 2019

Description

I'm added range values to rangeSliderThumbShape paint method.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 5, 2019
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@BondarenkoStas
Copy link

@encosw Please follow the PR template. Edit it in the was to be sure to explain why you want to do that change, provide related issues, tests (although there may be no need with these changes), follow the checklist as well etc.

@BondarenkoStas BondarenkoStas added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 9, 2019
@Piinks
Copy link
Contributor

Piinks commented Jan 7, 2020

The waiting for customer response bot would have closed this by now. Since this has not been updated in a few months I am going to close it. Please feel free to reopen if you would like to continue working on this. Thanks! :)

@Piinks Piinks closed this Jan 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants