Update ToggleButtons constraints default and add new constraints parameter #39857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihaohong
added
c: new feature
HansMuller
approved these changes
Sep 11, 2019
| } | ||
|
|
||
| final TextStyle currentTextStyle = textStyle ?? toggleButtonsTheme.textStyle ?? theme.textTheme.body1; | ||
| final BoxConstraints currentConstraints = constraints ?? toggleButtonsTheme.constraints ?? const BoxConstraints(minWidth: 48.0, minHeight: 48.0); |
| /// Typically used to constrain the button's minimum size. | ||
| /// | ||
| /// If this property is null, then | ||
| /// BoxConstraints(minWidth: 48.0, minHeight: 48.0) is be used. |
Contributor
There was a problem hiding this comment.
Although the 48 is kMinInteractiveDimension I think the documentation is easier to understand the way you have it.
15 tasks
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…meter (flutter#39857) * Add constraints property, updated default constraints for ToggleButtons to 48x48 * Add kMinInteractiveDimension constant to ToggleButtons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is no way to control the constraints of each button in the ToggleButtons widget. It currently defaults to const
BoxConstraints(minWidth: 88.0, minHeight: 36.0), which is the constraints for RawMaterialButton, but this is undesirable if we want it to look like the square toggle buttons.This PR does the following:
constraintsparameter to ToggleButtons and ToggleButtonsThemeRequired Follow-up
Related Issues
Fixes #39216
Tests
I added the following tests:
constraintsparameterChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?