Skip to content

WIP Skia Gold Support for Local & PreSubmit Testing in package:flutter #39853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Piinks wants to merge 10 commits into from
Closed

WIP Skia Gold Support for Local & PreSubmit Testing in package:flutter #39853

Piinks wants to merge 10 commits into from

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 4, 2019 •
edited
Loading

Description

WIP
Design Doc: flutter.dev/go/golden-workflow. Feedback is welcome here and in the design doc.

Status: Will complete testing and documentation when design is finalized.

Needs to land first:

Related Issues

WIP

Tests

WIP

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Sep 4, 2019
@Piinks Piinks changed the title WIP Local & PreSubmit Testing Support for Skia Gold WIP Local & PreSubmit Testing Support for Skia Gold for package:flutter Sep 4, 2019
@Piinks Piinks changed the title WIP Local & PreSubmit Testing Support for Skia Gold for package:flutter WIP Skia Gold Support for Local & PreSubmit Testing in package:flutter Sep 4, 2019
@goderbauer
Copy link
Member

goderbauer commented Sep 5, 2019

Closed as per @Piinks's request.

@goderbauer goderbauer closed this Sep 5, 2019
@Piinks Piinks mentioned this pull request Sep 12, 2019
Merged
1 task
@Piinks
Copy link
Contributor Author

Piinks commented Sep 12, 2019

Re-opening after resolving server issues.

@Piinks Piinks reopened this Sep 12, 2019
@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Sep 12, 2019
@Piinks Piinks added work in progress; do not review and removed f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Sep 12, 2019
@Piinks
Copy link
Contributor Author

Piinks commented Sep 16, 2019

Major merge conflicts from #39983. Will re-open as a new PR.

@Piinks Piinks closed this Sep 16, 2019
This was referenced Sep 16, 2019
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @goderbauer @googlebot @fluttergithubbot