Minor cleanup and prevent multiple exit #39751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #39751 +/- ##
==========================================
- Coverage 57.23% 56.81% -0.43%
==========================================
Files 194 194
Lines 18685 18686 +1
==========================================
- Hits 10695 10616 -79
- Misses 7990 8070 +80
Continue to review full report at Codecov.
|
yjbanov
approved these changes
Sep 3, 2019
| await chrome.chromeConnection.getTabs(); | ||
| } catch (e) { | ||
| await chrome.close(); | ||
| print('here'); |
Contributor
There was a problem hiding this comment.
This should've been "Jonah was here" 😛
| await connectionInfoCompleter.future; | ||
|
|
||
| await residentWebRunner.exit(); | ||
| await residentWebRunner.exit(); |
Contributor
There was a problem hiding this comment.
Maybe a comment line above explaining what might be unsafe about it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try and prevent case where _cleanup might be called twice (timing sensitive). Remove stray debug print and indentation fix in chrome.dart/