Skip to content

Conversation

@christopherfujino
Copy link
Contributor

This broke the devicelab.

Reverts #39505

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 30, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@shihaohong
Copy link
Contributor

RSLGTM

@christopherfujino christopherfujino merged commit 61eab16 into master Aug 30, 2019
@christopherfujino christopherfujino deleted the revert-39505-fix-devicelab-gradlew branch August 30, 2019 23:07
@christopherfujino
Copy link
Contributor Author

Actually, looks like the failures were infra-related and the initial PR was actually good...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants