Revert "Roll engine 9a17d8e45197..101e03c1c841 (4 commits)" #39540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6099f83.
Contributor
Author
Contributor
|
LGTM. @a-siva has dart added a new core lib for wasm? |
Contributor
Author
|
The fix is pending here: flutter/engine#11736 It was not added to the sky_engine rule, so dartdocs crashes trying to create docs for it |
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39534
This is breaking the docs shard, see https://cirrus-ci.com/task/4755278756577280
The dart:wasm library was not added to the sky_engine rule, so the local dart sdk sources are in an inconsistent state (see flutter/engine@74a3c73)