fix recursiveCopy to preserve executable bit #39505
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
c: contributor-productivity
digiter
left a comment
digiter
left a comment
There was a problem hiding this comment.
LGTM, although I'd prefer keeping the same file mode as the original, as it's a surprise to see more executable bits after copying.
We only add the executable bit to the copied file if the source file had it |
|
But chmod a+x will give executable bit to all of owner/group/other. |
oh, good point |
christopherfujino
force-pushed
the
fix-devicelab-gradlew
branch
from
01c5ae3 to
310ccaf
Compare
|
landing on red to fix |
This reverts commit 8ec2c58.
5 participants
Description
Copying the fix from this PR to
gradle.dart#311, the recursive copying should check if the target file had the executable bit set, and then make the copied file executable. This was causingsmoke_catalina_hot_mode_dev_cycle__benchmarkdevicelab test to be flaky.