Skip to content

Reland "Relax arguments around local engine, build hello_world with bitcode" #39434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 2 commits into from
Aug 28, 2019
Merged

Reland "Relax arguments around local engine, build hello_world with bitcode" #39434

dnfield merged 2 commits into from
Aug 28, 2019

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Aug 28, 2019 •
edited
Loading

Relands #39357

This failed on the devicelab because the binary stub we build for JIT based builds needs to have embedded bitcode as well. I'm always embedding a bitcode marker here, because it should always be safe to do so. Relevant change is in a2009ce

Fixes #15288 again

Even JIT gets bitcode

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 28, 2019
jonahwilliams
jonahwilliams approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmagman
jmagman reviewed Aug 28, 2019
View reviewed changes
packages/flutter_tools/bin/xcode_backend.sh

RunCommand eval "$(echo "static const int Moo = 88;" | xcrun clang -x c \
${arch_flags} \
-fembed-bitcode-marker \
Copy link
Member

@jmagman jmagman Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this.

jmagman
jmagman approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 28, 2019 •
edited
Loading

Codecov Report

Merging #39434 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39434      +/-   ##
==========================================
- Coverage    57.2%   57.17%   -0.03%     
==========================================
  Files         195      195              
  Lines       18510    18496      -14     
==========================================
- Hits        10588    10575      -13     
+ Misses       7922     7921       -1
Flag Coverage Δ
#flutter_tool 57.17% <50%> (-0.03%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/macos/xcode.dart 57.14% <0%> (-3.58%) ⬇️
packages/flutter_tools/lib/src/base/build.dart 68.06% <100%> (+0.03%) ⬆️
...ages/flutter_tools/lib/src/commands/build_aot.dart 37.5% <66.66%> (-1.76%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.9% <0%> (-1.92%) ⬇️
packages/flutter_tools/lib/src/device.dart 55.42% <0%> (-1.81%) ⬇️
packages/flutter_tools/lib/src/cache.dart 43.02% <0%> (-0.73%) ⬇️
packages/flutter_tools/lib/src/base/logger.dart 82.06% <0%> (-0.39%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 37.3% <0%> (+0.15%) ⬆️
packages/flutter_tools/lib/src/base/process.dart 86.45% <0%> (+0.64%) ⬆️
...ages/flutter_tools/lib/src/macos/macos_device.dart 62.74% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393106f...a2009ce. Read the comment docs.

@dnfield
Copy link
Contributor Author

dnfield commented Aug 28, 2019

Going to land this while the tree is green - the windows related tests that are still pending have no relevance to this change.

@dnfield dnfield merged commit cb96549 into flutter:master Aug 28, 2019
@dnfield dnfield deleted the bitcode_even_for_jit branch August 28, 2019 22:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Bitcode support for iOS

5 participants

@dnfield @jmagman @jonahwilliams @googlebot @fluttergithubbot