Skip to content

Revert "Relax requirements around local engine, build hello_world with bitcode" #39431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Aug 28, 2019
Merged

Revert "Relax requirements around local engine, build hello_world with bitcode" #39431

jonahwilliams merged 1 commit into from
Aug 28, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Aug 28, 2019

Reverts #39357

This is breaking ios_compile and the hello_world_ios

TBR @dnfield

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 28, 2019
@jonahwilliams jonahwilliams merged commit 393106f into master Aug 28, 2019
dnfield added a commit to dnfield/flutter that referenced this pull request Aug 28, 2019
@dnfield
Reland "Relax requirements around local engine, build hello_world wit…
0e18f1c 
…h bitcode (flutter#39357)" (flutter#39431)"

This reverts commit 393106f.
@dnfield dnfield deleted the revert-39357-bitcode_for_all branch August 28, 2019 21:15
dnfield
dnfield reviewed Aug 28, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @dnfield @googlebot @fluttergithubbot