Disable waitUntilFirstFrameRasterized #39212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And mark flutter_gallery__transition_perf as non-flaky so people won't break it without affecting the tree. However, the error log doesn't seem to suggest that the flakiness is due to `waitUntilFirstFrameRasterized`. Moreover, the ios and io32 versions of that test are working properly without any flakiness. Therefore, I'm not confident that this will fix the flakiness. But hopefully it will help solving the flakiness.
fluttergithubbot
added
d: examples
Contributor
Author
|
Abandon as the flakiness doesn't seem to be caused by waitUntilFirstFrameRasterized. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And mark flutter_gallery__transition_perf as non-flaky so people won't
break it without affecting the tree.
However, the error log doesn't seem to suggest that the flakiness
is due to
waitUntilFirstFrameRasterized. Moreover, the ios and io32versions of that test are working properly without any flakiness.
Therefore, I'm not confident that this will fix the flakiness. But
hopefully it will help solving the flakiness.