Skip to content

Conversation

@shihaohong
Copy link
Contributor

Description

Pull out double values into named variables with a comment to explain why the values are unique and consist of random, longer double values.

Related Issues

Fixes #39012

Tests

I added the following tests:

n/a

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@shihaohong shihaohong added the framework flutter/packages/flutter repository. See also f: labels. label Aug 22, 2019
@shihaohong shihaohong requested a review from HansMuller August 22, 2019 15:15
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong merged commit f0656ac into flutter:master Aug 22, 2019
@shihaohong shihaohong deleted the media-query-constants branch August 22, 2019 17:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Magic Numbers with Constants in media_query_test.dart

3 participants