Replace deprecated onReportTimings w/ frameTimings #38861
Conversation
fluttergithubbot
added
the
framework
liyuqian
force-pushed
the
use_frame_timings
branch
from
d7634d7 to
8c2657d
Compare
liyuqian
force-pushed
the
use_frame_timings
branch
from
8c2657d to
f6a5c0e
Compare
liyuqian
force-pushed
the
use_frame_timings
branch
from
f6a5c0e to
485b889
Compare
liyuqian
changed the title
liyuqian
added
c: performance
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
lgtm for the change; I would confirm whether this needs to follow the breaking change process before landing
| @override | ||
| // use frameTimings. https://github.com/flutter/flutter/issues/38838 | ||
| // ignore: deprecated_member_use | ||
| TimingsCallback get onReportTimings => _window.onReportTimings; |
There was a problem hiding this comment.
Do these changes need to go through the API breaking change process?
onReportTimings and TimingsCallback are very unlikely to have users, but we may want to email the announce list as part of this change.
There was a problem hiding this comment.
This is the flutter_test/.../window.dart instead of lib/ui/window.dart. Removing this doesn't remove the onReportTimings API (as it's inherited from lib/ui/window.dart) so this is not a breaking change.
There was a problem hiding this comment.
Ah, sorry, I did think this was in a lib/ directory; nevermind re: the breaking change.
There was a problem hiding this comment.
The TestWindow is part of the flutter_test api. So this may break somebody who was using tester.binding.window. onReportTimings in their test. I don't think that is very common, but it may still be worth to send a quick note?
There was a problem hiding this comment.
Breaking Change email sent with the tracking issue: #39277
|
@goderbauer : can you please double check that this is not a breaking change? |
6 participants
This is the continuation of flutter/engine#11041 and #38574
This is not a breaking change as we're not removing
onReportTimingsAPI.We're simply removing the use of it in our framework.