Fix analyzer issues for onReportTiming to frameTiming #38840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filed: flutter#38838 to track these usages. This was introduced by: flutter/engine#11041
fluttergithubbot
added
a: tests
Contributor
|
cc @mehmetf Won't this also trip analyzer warnings in fuchsia-source and google? |
Contributor
Author
|
@jonahwilliams true. I'll leave it to @liyuqian to decide on the best next steps here. |
Contributor
|
Considering that the commit is already in the framework, I think this PR is the fastest way to fix the tree. @jonahwilliams @mehmetf @cbracken @stuartmorgan : For the next Google3 and Fuchsia roll, we need to apply the |
Member
|
Why didn't we fix this by using the new API? |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filed: #38838
to track these usages.
This was introduced by: flutter/engine#11041