Skip to content

Unit test for build.dart::GenSnapshot #37642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liamappelbe merged 4 commits into from
Sep 23, 2019
Merged

Unit test for build.dart::GenSnapshot #37642

liamappelbe merged 4 commits into from
Sep 23, 2019

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Aug 5, 2019

Description

Adds a unit test for the GenSnapshot class. This is a follow up to #37445

Related Issues

#22598

Tests

Added a GenSnapshot test to build_test.dart

@liamappelbe liamappelbe requested a review from cbracken August 5, 2019 20:46
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019 •
edited
Loading

Codecov Report

Merging #37642 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #37642     +/-   ##
=========================================
+ Coverage   60.62%   60.82%   +0.2%     
=========================================
  Files         192      192             
  Lines       18401    18401             
=========================================
+ Hits        11155    11192     +37     
+ Misses       7246     7209     -37
Flag Coverage Δ
#flutter_tool 60.82% <ø> (+0.2%) ⬆️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/version.dart 75.84% <0%> (-18.85%) ⬇️
packages/flutter_tools/lib/src/base/os.dart 23.01% <0%> (-7.15%) ⬇️
packages/flutter_tools/lib/src/cache.dart 47.76% <0%> (-0.71%) ⬇️
.../flutter_tools/lib/src/runner/flutter_command.dart 83.33% <0%> (-0.44%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 41.06% <0%> (-0.17%) ⬇️
packages/flutter_tools/lib/src/commands/run.dart 64.7% <0%> (+0.49%) ⬆️
packages/flutter_tools/lib/src/compile.dart 80.14% <0%> (+0.7%) ⬆️
packages/flutter_tools/lib/src/base/utils.dart 95.97% <0%> (+1%) ⬆️
packages/flutter_tools/lib/src/run_hot.dart 69.07% <0%> (+3.28%) ⬆️
...ackages/flutter_tools/lib/src/resident_runner.dart 56.82% <0%> (+3.66%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6911a15...4f8bea0. Read the comment docs.

zanderso
zanderso reviewed Sep 12, 2019
View reviewed changes
@liamappelbe liamappelbe merged commit b0563e1 into flutter:master Sep 23, 2019
@liamappelbe liamappelbe deleted the gen_snapshot_test branch September 23, 2019 17:09
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@liamappelbe @Inconnu08
Unit test for build.dart::GenSnapshot (flutter#37642)
c8c37e5 
* Unit test for build.dart::GenSnapshot

* Fix analysis errors

* Switch to testLogger
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liamappelbe @zanderso @googlebot @fluttergithubbot