Skip to content

[WIP] Symlink Flutter.framework when the ephemeral directory gets generated from the template #37450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmagman wants to merge 3 commits into from
Closed

[WIP] Symlink Flutter.framework when the ephemeral directory gets generated from the template #37450

jmagman wants to merge 3 commits into from

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 2, 2019 •
edited
Loading

Description

When the pubspec changes in an add-to-app module, flutter pub get will trigger a regeneration of the ephemeral directory from the template. If flutter build ios isn't run in the module or pod install in the host app, the framework never gets copied from the engine artifacts cache, and the Xcode host app won't subsequently compile.

Tests

Re-enable flaky test turned off in #37442.
Add check for these directories.

Related Issues

Fixes #37525.
Fixes #42956

@jmagman jmagman self-assigned this Aug 2, 2019
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 2, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 2, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

/cc @dnfield

@jmagman jmagman mentioned this pull request Aug 2, 2019
Merged
@Hixie
Copy link
Contributor

Hixie commented Aug 2, 2019

Might be worth documenting that the file is important somewhere (maybe in the file itself?)

@jmagman
Copy link
Member Author

jmagman commented Aug 3, 2019

Might be worth documenting that the file is important somewhere (maybe in the file itself?)

I don't think it is important since adding it back didn't make the integration_tests-macos pass. It was a failed theory.

@jmagman jmagman changed the title [WIP] Add gitkeep back [WIP] Fix module_test_ios Aug 3, 2019
@Hixie
Copy link
Contributor

Hixie commented Aug 4, 2019

pity

@jmagman jmagman force-pushed the flaky-test branch 2 times, most recently from 357d537 to 9262c47 Compare October 14, 2019 22:22
@codecov
Copy link

codecov bot commented Oct 14, 2019 •
edited
Loading

Codecov Report

Merging #37450 into master will decrease coverage by 3.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37450      +/-   ##
==========================================
- Coverage   62.45%   59.04%   -3.41%     
==========================================
  Files         198      194       -4     
  Lines       19166    18877     -289     
==========================================
- Hits        11970    11146     -824     
- Misses       7196     7731     +535
Flag Coverage Δ
#flutter_tool 59.04% <ø> (-3.41%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/executable.dart 0% <0%> (-92.86%) ⬇️
...ges/flutter_tools/lib/src/commands/ide_config.dart 0% <0%> (-84.32%) ⬇️
packages/flutter_tools/lib/src/base/platform.dart 7.14% <0%> (-57.15%) ⬇️
...es/flutter_tools/lib/src/base/process_manager.dart 9.09% <0%> (-45.46%) ⬇️
...ckages/flutter_tools/lib/src/commands/analyze.dart 0% <0%> (-38.71%) ⬇️
...kages/flutter_tools/lib/src/commands/packages.dart 0% <0%> (-32%) ⬇️
...ackages/flutter_tools/lib/src/commands/unpack.dart 0% <0%> (-31.17%) ⬇️
...ckages/flutter_tools/lib/src/base/file_system.dart 42.59% <0%> (-27.59%) ⬇️
...ackages/flutter_tools/lib/src/commands/format.dart 0% <0%> (-25%) ⬇️
packages/flutter_tools/lib/src/run_cold.dart 19.51% <0%> (-24.02%) ⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba26f92...1f97deb. Read the comment docs.

@jmagman jmagman force-pushed the flaky-test branch 3 times, most recently from 7523638 to 2996519 Compare November 5, 2019 03:52
@jmagman jmagman changed the title [WIP] Fix module_test_ios [WIP] Symlink Flutter.framework when the ephemeral directory gets generated from the template Nov 5, 2019
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 5, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 5, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman jmagman added a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically labels Nov 5, 2019
@jmagman jmagman mentioned this pull request Dec 3, 2019
Closed
@jmagman
Copy link
Member Author

jmagman commented Dec 11, 2019

Superseded by #45877

@jmagman jmagman closed this Dec 11, 2019
@jmagman jmagman deleted the flaky-test branch December 21, 2019 00:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to build iOS app after modifying pubspec.yaml and running flutter pub get Deflake and re-enable module_test_ios

4 participants

@jmagman @fluttergithubbot @Hixie @googlebot