Skip to content

Disable flaky test #37442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Aug 2, 2019
Merged

Disable flaky test #37442

jmagman merged 1 commit into from
Aug 2, 2019

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 2, 2019

Description

Temporarily disable module_test_ios.

Failing in various places:

[module_test_ios] [STDOUT] ══════════════════════╡ ••• Build editable host app ••• ╞═══════════════════════
[module_test_ios] [STDOUT] 
[module_test_ios] [STDOUT] 
[module_test_ios] [STDOUT] Executing: /private/tmp/flutter sdk/dev/devicelab/../../bin/flutter build ios --no-codesign
[module_test_ios] [STDOUT] stdout: Warning: Building for device with codesigning disabled. You will have to manually codesign before deploying to device.
[module_test_ios] [STDOUT] stdout: Building io.flutter.devicelab.hello for device (ios-release)...
[module_test_ios] [STDOUT] stdout: Running pod install...                                              1.9s
[module_test_ios] [STDOUT] stdout: Running Xcode build...                                          
[module_test_ios] [STDOUT] stdout: Xcode build done.                                           50.3s
[module_test_ios] [STDOUT] stdout: Failed to build iOS app
[module_test_ios] [STDOUT] stdout: Error output from Xcode build:
[module_test_ios] [STDOUT] stdout: ↳
[module_test_ios] [STDOUT] stdout:     ** BUILD FAILED **
[module_test_ios] [STDOUT] stdout: 
[module_test_ios] [STDOUT] stdout: 
[module_test_ios] [STDOUT] stdout: Xcode's output:
[module_test_ios] [STDOUT] stdout: ↳
[module_test_ios] [STDOUT] stdout:     ld: warning: directory not found for option '-L/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.Mih0sJ/hello/ios/Flutter'
[module_test_ios] [STDOUT] stdout:     ld: warning: directory not found for option '-F/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.Mih0sJ/hello/ios/Flutter'
[module_test_ios] [STDOUT] stdout:     ld: warning: directory not found for option '-F/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.Mih0sJ/hello/ios/Flutter/engine'
[module_test_ios] [STDOUT] stdout:     error: the following command failed with exit code 0 but produced no further output
[module_test_ios] [STDOUT] stdout:     Ld /Users/anka/Library/Developer/Xcode/DerivedData/Runner-fpxmjflbcpiljkejkqkayxscoekl/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/Objects-normal/arm64/Runner normal arm64
[module_test_ios] [STDOUT] stdout:     ld: warning: directory not found for option '-L/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.Mih0sJ/hello/ios/Flutter'
[module_test_ios] [STDOUT] stdout:     ld: warning: directory not found for option '-F/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.Mih0sJ/hello/ios/Flutter'
[module_test_ios] [STDOUT] stdout:     ld: warning: directory not found for option '-F/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.Mih0sJ/hello/ios/Flutter/engine'
[module_test_ios] [STDOUT] stdout:     error: the following command failed with exit code 0 but produced no further output
[module_test_ios] [STDOUT] stdout:     Ld /Users/anka/Library/Developer/Xcode/DerivedData/Runner-fpxmjflbcpiljkejkqkayxscoekl/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/Objects-normal/armv7/Runner normal armv7
[module_test_ios] [STDOUT] stdout:     error: /var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.Mih0sJ/hello/.ios/Flutter/engine/Flutter.framework: No such file or directory

[module_test_ios] [STDOUT] ═════╡ ••• Build ephemeral host app in release mode without CocoaPods ••• ╞═════
[module_test_ios] [STDOUT] 
[module_test_ios] [STDOUT] 
[module_test_ios] [STDOUT] Executing: /private/tmp/flutter sdk/dev/devicelab/../../bin/flutter build ios --no-codesign
[module_test_ios] [STDOUT] stdout: Downloading ios tools...                                           12.1s
[module_test_ios] [STDOUT] stdout: Downloading ios-profile tools...                                   10.2s
[module_test_ios] [STDOUT] stdout: Downloading ios-release tools...                                    9.4s
[module_test_ios] [STDOUT] stdout: Warning: Building for device with codesigning disabled. You will have to manually codesign before deploying to device.
[module_test_ios] [STDOUT] stdout: Building io.flutter.devicelab.hello for device (ios-release)...
[module_test_ios] [STDOUT] stdout: Running Xcode build...                                          
[module_test_ios] [STDOUT] stdout: Xcode build done.                                           39.4s
[module_test_ios] [STDOUT] stdout: Failed to build iOS app
[module_test_ios] [STDOUT] stdout: Error output from Xcode build:
[module_test_ios] [STDOUT] stdout: ↳
[module_test_ios] [STDOUT] stdout:     ** BUILD FAILED **
[module_test_ios] [STDOUT] stdout: 
[module_test_ios] [STDOUT] stdout: 
[module_test_ios] [STDOUT] stdout: Xcode's output:
[module_test_ios] [STDOUT] stdout: ↳
[module_test_ios] [STDOUT] stdout:     /var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.lymmcF/hello/.ios/Runner/main.m:1:9: fatal error: 'Flutter/Flutter.h' file not found
[module_test_ios] [STDOUT] stdout:     #import <Flutter/Flutter.h>
[module_test_ios] [STDOUT] stdout:             ^~~~~~~~~~~~~~~~~~~
[module_test_ios] [STDOUT] stdout:     1 error generated.

[module_test_ios] [STDOUT] ══════════════╡ ••• Build ephemeral host app with CocoaPods ••• ╞═══════════════
[module_test_ios] [STDOUT] 
[module_test_ios] [STDOUT] 
[module_test_ios] [STDOUT] Executing: /private/tmp/flutter sdk/dev/devicelab/../../bin/flutter build ios --no-codesign
[module_test_ios] [STDOUT] stdout: Warning: Building for device with codesigning disabled. You will have to manually codesign before deploying to device.
[module_test_ios] [STDOUT] stdout: Building io.flutter.devicelab.hello for device (ios-release)...
[module_test_ios] [STDOUT] stderr: Podfile missing

@jmagman jmagman requested a review from dnfield August 2, 2019 00:19
@jmagman jmagman self-assigned this Aug 2, 2019
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 2, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Aug 2, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

/cc @dnfield

@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 2, 2019
@jmagman
Copy link
Member Author

jmagman commented Aug 2, 2019

https://cirrus-ci.com/task/5429447094697984?command=test_all
https://cirrus-ci.com/task/4820973524615168?command=test_all

@xster
Copy link
Member

xster commented Aug 2, 2019

LGTM

@jmagman jmagman merged commit af1bbc4 into flutter:master Aug 2, 2019
@jmagman jmagman deleted the flaky branch August 2, 2019 00:46
@jmagman jmagman mentioned this pull request Aug 2, 2019
Closed
@Hixie
Copy link
Contributor

Hixie commented Aug 2, 2019

https://cirrus-ci.com/task/4863785758621696?command=test_all also saw this.

@Hixie
Copy link
Contributor

Hixie commented Aug 2, 2019

Did we file a bug on the actual failure?

@jmagman
Copy link
Member Author

jmagman commented Aug 2, 2019

Did we file a bug on the actual failure?

No, I have a WIP PR at #37450. I can file one.

@jmagman jmagman mentioned this pull request Aug 2, 2019
Closed
@jmagman
Copy link
Member Author

jmagman commented Aug 2, 2019

Did we file a bug on the actual failure?

No, I have a WIP PR at #37450. I can file one.

#37525

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmagman @fluttergithubbot @xster @Hixie @dnfield @googlebot