Fix selection menu not showing after clear #37042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
added
a: text input
justinmc
commented
Jul 26, 2019
| } | ||
| } | ||
|
|
||
| void _hideSelectionOverlayIfNeeded() { |
Contributor
Author
There was a problem hiding this comment.
I think some of the problem came from the fact that there are two subtly different methods with confusing names: _hideSelectionOverlayIfNeeded and hideToolbar. I got rid of this one altogether and I think it makes more sense now.
HansMuller
approved these changes
Jul 29, 2019
| }); | ||
|
|
||
| tearDown(() { | ||
| controller = null; |
Contributor
There was a problem hiding this comment.
controller.dispose() first?
| await tester.pump(); | ||
| expect(find.text('PASTE'), findsOneWidget); | ||
|
|
||
| // Hide the toolbar and clear the text and selection. |
Contributor
There was a problem hiding this comment.
Maybe factor this out as a separate test and mark it as a regression test for #35998
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you long press an empty text field, then the selection menu shows, but if you type some content and then delete it all so it's empty again, the menu doesn't show. This PR fixes that.
Related Issues
Closes #35998
Tests
Tested adding text, deleting it, and then showing the menu in editable_text_test.dart.