Update SnackBar to the latest Material specs. #37038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenaustin
added
framework
HansMuller
reviewed
Jul 26, 2019
Contributor
There was a problem hiding this comment.
Shouldn't this inverseTheme's colorScheme have a similar secondary color? Shouldn't it have a new color scheme?
Contributor
There was a problem hiding this comment.
Maybe open an issue about the need for a proper inverse color scheme here.
rami-a
approved these changes
Jul 30, 2019
Contributor
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
LGTM with one minor comment!
| final ThemeData inverseTheme = ThemeData( | ||
| brightness: brightness, | ||
| backgroundColor: themeBackgroundColor, | ||
| colorScheme: ColorScheme( |
Contributor
There was a problem hiding this comment.
I think you could maybe use copyWith here to make this a bit more concise since you only want to change the secondary color and the brightness.
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bringing the SnackBar up to spec:
Light theme:
Dark theme:
Related Issues
Fixes #31418
Tests
Added new tests to check the background color in both light and dark themes.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?