Skip to content

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jul 25, 2019

No description provided.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 25, 2019
@jason-simmons jason-simmons requested a review from dnfield July 25, 2019 22:19
@Hixie
Copy link
Contributor

Hixie commented Jul 25, 2019

(for archeology purposes, can you briefly describe the motivation for this change? thanks)

@dnfield
Copy link
Contributor

dnfield commented Jul 25, 2019

This LGTM, would also appreciate the explanation. It looks to me like this was added as a way to set the local engine before we could just pass --local-engine to the command, and now that we can do that it gets confusing when both are set.

@jason-simmons
Copy link
Member Author

The devicelab script contained a feature that was intended to let you run a devicelab test with a local engine build by setting the FLUTTER_ENGINE environment variable. I don't know if this feature was ever widely used. But it was placing the --local-engine flag in the wrong place in the flutter_tools command line, so it doesn't currently work.

Recently a --local-engine flag was added to the devicelab command line. That flag works for most devicelab tests (which run flutter_tools through functions in lib/framework/utils.dart). This PR updates the remaining tests to support the --local-engine flag and removes the obsolete FLUTTER_ENGINE variable.

@jason-simmons jason-simmons force-pushed the devicelab_set_local_option branch from f55747a to 680c07b Compare July 25, 2019 23:31
@jason-simmons jason-simmons merged commit a3a350d into flutter:master Jul 26, 2019
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants