Skip to content

Remove stdout related to settings_aar.gradle #36949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 1 commit into from
Jul 25, 2019
Merged

Remove stdout related to settings_aar.gradle #36949

blasten merged 1 commit into from
Jul 25, 2019

Conversation

@blasten
Copy link

@blasten blasten commented Jul 25, 2019

Fixes #36923

@blasten blasten added a: tests "flutter test", flutter_test, or one of our tests t: flutter driver "flutter driver", flutter_drive, or a driver test labels Jul 25, 2019
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 25, 2019
@blasten blasten requested a review from jonahwilliams July 25, 2019 15:42
jonahwilliams
jonahwilliams approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thanks!

@blasten
Copy link
Author

blasten commented Jul 25, 2019

Merging before finishing the presubmit checks since this test only runs after.

@blasten blasten merged commit a37921f into flutter:master Jul 25, 2019
@blasten blasten deleted the run_release_test branch July 25, 2019 15:52
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@johnsonmh
Remove stdout related to settings_aar.gradle (flutter#36949)
16fb72e 
Fixes flutter#36923
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. t: flutter driver "flutter driver", flutter_drive, or a driver test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

run_release_test flaky after #36732

4 participants

@blasten @jonahwilliams @googlebot @fluttergithubbot