Remove multi-arch check in iOS builds #36710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygine page and make sure this patch meets those guidelines before LGTMing. /cc @dnfield |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
…ip defaults (#36856) * Implement TooltipThemeData and TooltipTheme * Add text style property * Updated tooltip default colors for light and dark theme to match Material specification
* 876eff6 Revert "[fuchsia] Use the patched sdk to generate the flutter jit runner far (#10122)" (flutter/engine#10140) * 36b5b14 Roll fuchsia/sdk/core/mac-amd64 from 9EcA--gzHNo80R_fAuB_Tq7ECubTP0Uz3UrycPIvRpsC to SHb_OsdvSz75N-G-jbG-tQOM1OyipLcQG0rsVrARsX0C (flutter/engine#10134) * 29d92c9 Roll src/third_party/skia b3956dc6ba6a..fff996c117c1 (10 commits) (flutter/engine#10133) * d50f415 Roll fuchsia/sdk/core/linux-amd64 from NrExSKBKIhY3SnE4sD0-vHjEMCBYYffzarRM2rWONUUC to ylNwUxj7tBGga6sghqrKH_gqu3RzfTLxB4rxZhAk2IAC (flutter/engine#10135) * 930f585 Roll fuchsia/clang/linux-amd64 from zHiuOGMDwdWPUkV1B2fHKyRy2fGWGcUgfa2z6dyGAZQC to W8LY5ncb-fknOtxPITszyAZ1g80_OSq2W_QWC3QunXoC (flutter/engine#10137) * 9c1bba3 Roll fuchsia/clang/mac-amd64 from UYD9C8IEkWVi83ef4zwO1Ump2B8cP9Nd5WECjU8l3AUC to CqfCCMwpILIYr4rqCeh3zF8x3qErehEusnQwl22i7KIC (flutter/engine#10136) * 0ecb793 ios: Fixed the callback for the first frame so that it isn't predicated on having a splash screen. (flutter/engine#9952) * 35b62dd Roll src/third_party/dart 0c97c31b6e..a2aec5eb06 (22 commits) (flutter/engine#10139) * 250ee31 Started linking the test targets against Flutter. (flutter/engine#10128) * 330b0f0 Revert "[macos] Revert check on FlutterCodecs and refactor message function] (#10009)" (flutter/engine#10141) * 0861e0a Disable windows tests (flutter/engine#10143)
flutter/engine@0861e0a...d8c9b10 git log 0861e0a..d8c9b10 --no-merges --oneline d8c9b10 [fucshia] fix name to reflect the cmx file (flutter/engine#10151) 3388781 Revert "Disable windows tests (#10143)" (flutter/engine#10146) ae5e611 Roll src/third_party/skia fff996c117c1..04aa81ae66bc (32 commits) (flutter/engine#10149) a6038d5 Roll fuchsia/sdk/core/linux-amd64 from ylNwUxj7tBGga6sghqrKH_gqu3RzfTLxB4rxZhAk2IAC to vHQ3m9W_pv1OLg6ch-uP3bu-VhWS-4PKZm4YrxjP-fAC (flutter/engine#10148) 5edd787 [fuchsia] Push CMX to fars and add product mode support (flutter/engine#10144) 70c8c3f Roll fuchsia/sdk/core/mac-amd64 from SHb_OsdvSz75N-G-jbG-tQOM1OyipLcQG0rsVrARsX0C to giU1d8T7pC6K7vuX0_0ZQpH_ZkzIbgvyao2ICAW6PS8C (flutter/engine#10147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
* Roll back the AAR build experiment This has been breaking flutter/plugins CI for the past day. * Remove integration tests that rely on the AAR flag
flutter/engine@d8c9b10...fc5dae7 git log d8c9b10..fc5dae7 --no-merges --oneline fc5dae7 Roll fuchsia/sdk/core/linux-amd64 from vHQ3m9W_pv1OLg6ch-uP3bu-VhWS-4PKZm4YrxjP-fAC to 343SsgVihcggviIigVC3WKmGJMWqASKDF0WKMZAy4ygC (flutter/engine#10157) eb09ebd Roll src/third_party/skia 04aa81ae66bc..1b53191539fc (4 commits) (flutter/engine#10158) 9bda68c Roll fuchsia/sdk/core/mac-amd64 from giU1d8T7pC6K7vuX0_0ZQpH_ZkzIbgvyao2ICAW6PS8C to gAv025of19MDIqAyY24hyZKFb8wFRrm3jsJmCEHYKL0C (flutter/engine#10156) a324bf4 flutter/engine@a2aec5eb06...86dba81dec (flutter/engine#10155) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
* Introduces ToggleButtons widget * Introduces ToggleButtonsTheme inherited widget * Introduces ThemeData.toggleButtonsTheme property
… turn on and off context menu options (#34676)
Sped up shader warmup by only drawing on a 100x100 surface and doing the draw calls on top of each other.
…ew local engine flags (#36969)
…yle of Menu (#36088) * [Menu] Create Menu theme * [Menu] Create Menu theme * [Menu] Formatting changes for Menu theme * [Menu] Fix spacing difference in theme_data.dart. * [Menu] Fix spacing difference in theme_data.dart. * Specifying types * Formatting changes * Address PR feedback * Formatting changes * Address PR feedback * Add inherited widget * Add inherited widget * Address PR feedback and add inherited widget. * Formatting changes. * Address PR feedback * Address PR feedback * Address PR feedback * Address PR feedback
[Material] Fix slider preferred height
flutter/engine@fc5dae7...2409dda git log fc5dae7..2409dda --no-merges --oneline 2409dda Roll fuchsia/sdk/core/mac-amd64 from krOfE-omNi34-7rwppwso1EdS03nxhIoYlP241wGj2UC to SjR5fqBfe7qxjHNWDZx6381UbPUcw78mDI9dFAIN-Y4C (flutter/engine#10170) 682e981 Roll src/third_party/skia 19fd32891f57..e81dd40406b8 (1 commits) (flutter/engine#10169) c3e808d Roll fuchsia/sdk/core/linux-amd64 from Av4jSk_2K0kEEj_Ci9oDpT1W9mJkfXL7gSi7xpN9TnQC to Ve72ZopgphfY0d_ROG21MI0EPX695oWIiMzxxK3fWk8C (flutter/engine#10168) 63286c1 Roll fuchsia/sdk/core/mac-amd64 from tp7OlQgwK8ZJKfwrZOw0HLkwXb2F1Zu9GF6gFeDIbXcC to krOfE-omNi34-7rwppwso1EdS03nxhIoYlP241wGj2UC (flutter/engine#10167) 55b6cac Roll fuchsia/sdk/core/linux-amd64 from aYeKcHzstlAmKW-JEPrBlTBATqMz_rAS4o_BtvhnRKQC to Av4jSk_2K0kEEj_Ci9oDpT1W9mJkfXL7gSi7xpN9TnQC (flutter/engine#10166) 3c893af Roll src/third_party/skia 6f615d6ebf9c..19fd32891f57 (1 commits) (flutter/engine#10165) 161e931 Roll fuchsia/sdk/core/mac-amd64 from NpXmT8OnPFwY7SNBfxhxCL_IIzAnuav2gQ2GoWgZlX8C to tp7OlQgwK8ZJKfwrZOw0HLkwXb2F1Zu9GF6gFeDIbXcC (flutter/engine#10163) 7df4755 Roll src/third_party/skia 1b53191539fc..6f615d6ebf9c (2 commits) (flutter/engine#10162) 4ba5cf8 Roll fuchsia/sdk/core/linux-amd64 from 343SsgVihcggviIigVC3WKmGJMWqASKDF0WKMZAy4ygC to aYeKcHzstlAmKW-JEPrBlTBATqMz_rAS4o_BtvhnRKQC (flutter/engine#10161) 8d1bd9e Roll fuchsia/sdk/core/mac-amd64 from gAv025of19MDIqAyY24hyZKFb8wFRrm3jsJmCEHYKL0C to NpXmT8OnPFwY7SNBfxhxCL_IIzAnuav2gQ2GoWgZlX8C (flutter/engine#10159) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Codecov Report
@@ Coverage Diff @@
## master #36710 +/- ##
==========================================
- Coverage 56.04% 54.23% -1.81%
==========================================
Files 188 191 +3
Lines 17432 17790 +358
==========================================
- Hits 9769 9648 -121
- Misses 7663 8142 +479
Continue to review full report at Codecov.
|
Contributor
Author
|
This PR is showing spurious diffs, so switching to #37407 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of flutter/engine#10010, iOS builds targeting armv7 are built using a 64-bit version of gen_snapshot that can produce 32-bit arm code. So this multi-arch special case is no longer necessary (and actually breaks the build).
Related Issues
#22598
Tests
I built the flutter examples in this mode using Xcode 10 and verified that they work on an iPhone 4S.