Added ThemeMode support to the Flutter Gallery #36399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the system's dark/light mode setting by default.
darrenaustin
added
the
customer: gallery
fluttergithubbot
added
d: examples
darrenaustin
changed the title
Updated the tests to the changes to the options page.
darrenaustin
changed the title
HansMuller
approved these changes
Jul 20, 2019
| 'kLightGalleryTheme', | ||
| 'ThemeData.light()', | ||
| // TODO(hansmuller): add 'kDarkGalleryTheme', 'ThemeData.dark()', see 22044 | ||
| // TODO(hansmuller): add 'kDarkGalleryTheme', 'ThemeData.dark()', see #22044 |
Contributor
There was a problem hiding this comment.
This issue (#22044) has been fixed; maybe add the dark theme?
Contributor
Author
There was a problem hiding this comment.
I did give the dark theme a go here, but there were still some tests that failed and I didn't have the chance to dive into them.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
Made the Flutter Gallery use the new ThemeMode property so that it can use the system's dark/light mode setting by default.
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the Flutter Gallery's 'Dark Theme' toggle button into a drop down menu that uses the new
ThemeModesettings to control which them is selected:If this is set to 'System Default' the Gallery will use either its light or dark theme based on the underlying platform's dark/light mode setting. If it is set to 'Light' then it will always use the light theme regardless of system settings, and if it is 'Dark' then it will always use the dark theme. It will default to 'System Default'.
See
MaterialApp.themeModedocumentation for more details.Related Issues
PR that introduced
ThemeMode: #35499Tests
I updated the smoke test and unit tests for the options page to match the new layout.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?