Optimize the transformRect and transformPoint methods in matrix_utils. #36396
+306
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily these methods no longer allocate any objects other than their return values. Additionally, the math in the methods is reduced compared to the general case math based on known input conditions.
fluttergithubbot
added
the
framework
dnfield
reviewed
Jul 17, 2019
dnfield
reviewed
Jul 17, 2019
dnfield
reviewed
Jul 17, 2019
dnfield
reviewed
Jul 17, 2019
Contributor
Author
|
Newest update resolves:
I did not add any code to compare test results to vector_math |
dnfield
approved these changes
Jul 19, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM - I would defer to yjbanov though
yjbanov
approved these changes
Jul 19, 2019
9 tasks
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Jul 26, 2019
…ix_utils. (flutter#36396)" This reverts commit 9946f7c.
dnfield
added a commit
that referenced
this pull request
Jul 27, 2019
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter#36396) Primarily these methods no longer allocate any objects other than their return values. Additionally, the math in the methods is reduced compared to the general case math based on known input conditions.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* Revert "Optimize the transformRect and transformPoint methods in matrix_utils. (flutter#36396)" This reverts commit 9946f7c. * add test
flar
added a commit
to flar/flutter
that referenced
this pull request
Jul 31, 2019
flutter#36396) Primarily these methods no longer allocate any objects other than their return values. Additionally, the math in the methods is reduced compared to the general case math based on known input conditions. Modified to no longer generate infinite values in some finite cases.
flar
added a commit
that referenced
this pull request
Jul 31, 2019
…ix_utils. (#36396) (#37275) Primarily these methods no longer allocate any objects other than their return values. Additionally, the math in the methods is reduced compared to the general case math based on known input conditions. Modified to no longer generate infinite values in some finite cases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily these methods no longer allocate any objects other than their
return values.
Additionally, the math in the methods is reduced compared to the general
case math based on known input conditions.
Results from a Moto E2 phone...
Before:
After:
Results from a Samsung Note 9...
Before
After: