Updated ColorScheme.dark() colors to match the Material Dark theme specification #36106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenaustin
added
framework
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygine page and make sure this patch meets those guidelines before LGTMing. /cc @dnfield |
colors to match the spec.
darrenaustin
changed the title
HansMuller
approved these changes
Jul 15, 2019
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
Please add a pair of (trivial) tests that verify the default light and dark color scheme colors per the spec.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
…ecification (flutter#36106) Updated ColorScheme.dark() primaryVariant, surface, background and error colors to match the spec.
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According the the Material Dark theme spec the default dark color scheme's
primaryVariant,surface,backgroundanderrorcolors should be:Which are different than the current implementation of
ColorScheme.dark(). As this is supposed to be the default dark theme for applications to use, it should use the recommended colors.This PR updates
ColorScheme.dark()to the match the spec colors.Related Issues
Fixes: #36021
Tests
Added a new
color_scheme_test.dartthat checks the light and dark scheme against the spec values.Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
If you depended on
ColorScheme.dark()to provide the current implementation's colors, then you can just usecopyWithto set those colors back to the original non-spec colors using the following:See the announcement email for more details.